Move more code from libpe_rules to libcrmcommon #3740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@wenningerk , here's the next chunk of this project |
|
Looking good as far as I can tell. Just comments and thoughts ... |
wenningerk
reviewed
Dec 10, 2024
This will replace pe_eval_nvpairs() and pe_unpack_nvpairs(). It is public API as that capability seems potentially useful and can't be done directly by external code due to needing to call internal APIs.
…taset_nvpairs() This involves converting the function and its callers to use pcmk_rule_input_t instead of pe_rule_eval_data_t.
… pe_rule_eval_data_t
…pe_rsc_eval_data_t
…pe_re_match_data_t
... since it contains only deprecated code now
libcib now uses rule APIs only from libcrmcommon
|
updated commits per review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows libcib to drop its linkage with libpe_rules