Issue #1980: Evaluation Summaries not populating with data

[markmandell]

Issue #1980 :
Here are the steps to recreate the bug and test this issue -

1. In a local instance without these changes, log in to VCI and curate a new variant. Create an interpretation, and evaluate some criteria to gain access to the Evaluation Summary. Save the initial form until you have saved the interpretation as 'Approved'.
2. Navigate to the Approved Summary, and open the browser console. Navigate to the network tab and choose either 'Fast 3G' or 'Slow 3G' (have been able to recreate using both, but slow option seems to be the most reliable method to get the error)
3. It may take a couple of tries but you should see an error along the lines of:
   

After browsing Stackoverflow/Github, specifically here, there was a suggestion that an inconsistency with dates may be an issue when receiving the above error. Also, the date is the only data that is being rendered here, with it being the current time, not the date the classification was saved.

If you comment out line 65 (the call to getClassificationSavedDate in render()) in /src/clincoded/static/components/variant_interpretation_summary/header.js, and keep the same network throttling in step 2, the error should not occur. If you pull in the changes from this branch, you will get the same result.

I assigned the desired date to a conditional in which getClassificationSavedDate will only be called if last_modified exists in the classification object. This is because the moment library was returning the current time upon the initial render (due to classification being undefined), and if the users connection was too slow to resolve this inconsistency, the Summary would error out. This is why some users reported this issue while others may not have encountered the bug at all. I set the else condition to be null, because if undefined, moment will return the current time, instead of 'Invalid Date'.

[h-tong]

This is a great catch! From my testing, this fixes the bug.

[h-tong]

What do you think about conditionally rendering this, so that the user doesn't see "Invalid Date"?

{lastSavedDate ?
  <dd>.......</dd>
  : null}

[markmandell]

Good suggestion! I'll implement and push the change

[shaungc-su]

The logic fix looks good to me.