Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Other User's Approved Evaluation Summaries not populating with data #1980

Closed
cgpreston opened this issue Jul 12, 2019 · 20 comments
Closed

Other User's Approved Evaluation Summaries not populating with data #1980

cgpreston opened this issue Jul 12, 2019 · 20 comments

Comments

@cgpreston
Copy link

Users report (and I see) that after clicking on the "two links" icon in the UI the evidence view is not populated. This behavior seems to be variable.

Things we tried:

  1. @wrightmw was able to see the evidence view for variant 17000
  2. @cgpreston was NOT able to see the evidence view for variant 17000
    1. Still could not see the evidence view after a hard refresh of the chrome browser
    2. Still could not see the evidence view after signing in on firefox
@wrightmw wrightmw changed the title Evidence View not populating Evaluation Summary not populating with data Jul 14, 2019
@wrightmw wrightmw changed the title Evaluation Summary not populating with data Other User's Approved Evaluation Summaries not populating with data Jul 14, 2019
@wrightmw
Copy link
Member

wrightmw commented Jul 14, 2019

In the "All interpretations for this variant in the Variant Curation Interface (VCI)" table in Basic Info tab of the VCI, clicking the linking icon for Interpretations with status "Approved" should always link a user to the full Evaluation Summary. As described above, sometimes users are directed to an empty form that has no data in it.

@sharriso Can you please provide a couple of examples of where you are unable to see any data populated in the Evaluation Summary when you click on the link? Thanks!

@wrightmw
Copy link
Member

@sharriso

@wrightmw
Copy link
Member

@bryanwulf This is the bug ticket we discussed in our meeting yesterday.

@sharriso
Copy link

image
In the top picture you can see that I am logged in as myself (no affiliation) and am on an MYH7 variant that shows an approved interp from an EP

And then I click on that little chain link to see the data and get this...
image

@sharriso
Copy link

Just tried a CDH1 variant and noticed something weird...in the top you can see it says "Login"...so clicking the link seems log me out? But if I try to login again with the button at top nothing happens
image

@cgpreston
Copy link
Author

@wrightmw, could you add a screenshot of one of the successful ones so we can compare to @sharriso example?

@wrightmw
Copy link
Member

A successful example would just be the filled out Evaluation Summary, as per usual.
This is the URL for Steven's example: https://curation.clinicalgenome.org/variant-central/?variant=26694b6b-670b-432a-ab96-9328f6e3d913

Here is the usual result I get when I click on the link (in this example, I am just logged in as me with no affiliation):
Screen Shot 2019-07-16 at 1 12 43 PM

@wrightmw
Copy link
Member

wrightmw commented Jul 16, 2019

And I get the same correct result when I'm logged in as an affiliation, and when I'm logged in under my other user account (which has no admin privileges).

@sharriso
Copy link

I just tried - used that link. Takes me to the first page (I'm logged in)
image

But then as soon as I click the hyperlink thingy, the new window opens and it shows I'm not logged in anymore
image

@wrightmw
Copy link
Member

@sharriso That is odd behavior. It should open in a separate tab and have no banner.

@sharriso
Copy link

Sorry I did mean new tab not new window!

@wrightmw
Copy link
Member

It keeps me logged in. @cgpreston does it log you out too?

@cgpreston
Copy link
Author

@sharriso , @wrightmw , I see the same thing as what Steven reported:

Steps:

  1. Navigated to link Matt provided
  2. Clicked on handcuff symbol

See as follows:
Screen Shot 2019-07-16 at 1 46 50 PM

@cgpreston
Copy link
Author

cgpreston commented Jul 16, 2019

It doesn't exactly "log me out", the home button is gone and the "close" button doesn't work, so it's more of a dead-end. I'm still logged into the VCI as far as I can tell when I navigate to other pages.

None of the following buttons do anything when I'm in this page:
"Help"
"Login"
Top right "Close"
Bottom right "Close"
"Print PDF"

This is the URL I get: https://curation.clinicalgenome.org/variant-interpretation-summary/?snapshot=91050c6f-cf43-4b78-87ed-e9e4525f2a04&status=Approved&affiliationId=10002

@wrightmw
Copy link
Member

wrightmw commented Aug 9, 2019

@bryanwulf We've had another user report this same issue. I've asked her for further clarification but this suggests we need look into how to resolve this bug.

FYI: @cgpreston

@wrightmw
Copy link
Member

wrightmw commented Aug 9, 2019

@bryanwulf The second user has responded with further information. She gets the blank Evaluation Summaries not just for ones approved by others, but also for ones that she Approved.

@wrightmw
Copy link
Member

wrightmw commented Aug 9, 2019

@wrightmw
Copy link
Member

@wrightmw wrightmw added this to the Release 28 milestone Aug 28, 2019
@wrightmw wrightmw removed the R28 label Aug 29, 2019
@wrightmw wrightmw modified the milestones: Release 28, Release 29 Oct 21, 2019
@cgpreston cgpreston modified the milestones: Release 29, Release 30 Oct 28, 2019
@cgpreston
Copy link
Author

Tested by VCI Proxy group with users in 3 different states, all reported they could see a previously approved summary and a recently approved summary. Thanks @markmandell!

@wrightmw
Copy link
Member

wrightmw commented Feb 7, 2020

R31 release

@wrightmw wrightmw closed this as completed Feb 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants