Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove excess unit conversion logging to INFO from dodola.service #148

Closed
brews opened this issue Dec 8, 2021 · 4 comments · Fixed by #168
Closed

Remove excess unit conversion logging to INFO from dodola.service #148

brews opened this issue Dec 8, 2021 · 4 comments · Fixed by #168
Assignees

Comments

@brews
Copy link
Member

brews commented Dec 8, 2021

We added automatic unit conversion in PR #143. This logs to INFO saying that unit conversion is happening for a variable.

It would be nice if we could drop those extra logging messages added to dodola.service from PR #143.

Instead we should put a logging message into dodola.core.xclim_units_any2pint and dodola.core.xclim_units_pint2cf, and be clear that a unit switch may happen, or maybe that it's converting cf units to paint units and vice-versa.

@emileten
Copy link
Contributor

emileten commented Dec 8, 2021

@brews I assigned this to myself. Let me know if you'd prefer to do it instead.

@brews
Copy link
Member Author

brews commented Dec 8, 2021

Naw, go for it, @emileten ! I appreciate the help. I'm happy to review the PR!

@emileten
Copy link
Contributor

emileten commented Dec 9, 2021

@brews how much of a priority is that for you ? So that I know where to put that in my todo list.

@brews
Copy link
Member Author

brews commented Dec 9, 2021

@emileten Low priority.

If you don't want to take it this week then I'd unassign yourself and someone else might pick it up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants