Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SYSTEM SYNC REPLICA call in exchange_tables_atomic macro missing space #167

Closed
damirbk opened this issue Jul 17, 2023 · 1 comment
Closed
Labels
bug Something isn't working

Comments

@damirbk
Copy link
Contributor

damirbk commented Jul 17, 2023

Describe the bug

The fix implemented in #156 will format the SQL in the following way:

SYSTEM SYNC REPLICA

ON CLUSTER "{cluster}"db.table_name

As you can see, compared to the documentation, there is a space missing between the ON CLUSTER clause and the db.table_name.

Expected behaviour

The rendered SQL should look like this:

SYSTEM SYNC REPLICA

ON CLUSTER "{cluster}" db.table_name

So simply a space should be added.

Configuration

Environment

  • dbt-clickhouse version: 1.4.2
@damirbk damirbk added the bug Something isn't working label Jul 17, 2023
@genzgd
Copy link
Contributor

genzgd commented Jul 19, 2023

PR with fix has been merged and released in 1.4.4

@genzgd genzgd closed this as completed Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants