Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(node): add paramters to forward OTEL Headers to Clickhouse #395

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

DylanRJohnston
Copy link

@DylanRJohnston DylanRJohnston commented Feb 26, 2025

Summary

Addresses #394, Clickhouse supports reading the OTEL HTTP headers from the connection

Checklist

  • Unit tests covering the common scenarios were added
  • A human-readable description of the changes was provided to include in CHANGELOG

@CLAassistant
Copy link

CLAassistant commented Feb 26, 2025

CLA assistant check
All committers have signed the CLA.

@DylanRJohnston DylanRJohnston changed the title [feat] add paramters to forward OTEL Headers to Clickhouse feat(node): add paramters to forward OTEL Headers to Clickhouse Feb 26, 2025
@mshustov mshustov requested a review from slvrtrn February 26, 2025 09:21
@slvrtrn
Copy link
Contributor

slvrtrn commented Feb 26, 2025

Thanks for the contribution.
I think it makes more sense to just allow overriding headers for a particular request in all methods. It also looks like that's what initially was proposed in the code snippet in the issue.
@mshustov WDYT?

@DylanRJohnston
Copy link
Author

@slvrtrn that makes sense, but what about the existing auth configuration parameters that get turned into headers? Should custom headers override them, or visa versa?

@DylanRJohnston
Copy link
Author

Also I had a look at the failing integration tests it seems that the CI environment is misconfigured?

@mshustov
Copy link
Member

I think it makes more sense to just allow overriding headers for a particular request in all methods. It also looks like that's what initially was proposed in the code snippet in the issue.

👍

what about the existing auth configuration parameters that get turned into headers? Should custom headers override them, or visa versa?

I'd vote for allowing users to override any headers (with a debug log record emitted that an override has happened) - it gives more power and flexibility to the end user. For example, one can implement multi-tenant runtime and mange users on the app level

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants