-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for role query parameters #328
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution! Tests are good, too. There is one thing that we should fix before merging (the example); the rest are mostly nitpicks
The CLA also needs to be signed before we merge it. |
Will do - I am working with my company to make sure I am not violating any of their open source policies by signing, but will sign as soon as I have approval. |
@pulpdrew, do you have any updates regarding the CLA? I'd like to merge this, but non-signed CLA is a blocker. |
@slvrtrn Hey, apologies for the delay. My company is still reviewing the CLA. 🫠 They tell me they should have an update for me early next week. I will reply here with an ETA next week once I hear from them! |
@slvrtrn I have signed the CLA, thanks for waiting! |
Summary
This PR adds support for specifying roles via request query parameters. Closes #269.
Checklist
Delete items not relevant to your PR: