Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove slf4j dependency from JDBC driver #741

Merged
merged 1 commit into from
Oct 10, 2021
Merged

Remove slf4j dependency from JDBC driver #741

merged 1 commit into from
Oct 10, 2021

Conversation

zhicwu
Copy link
Contributor

@zhicwu zhicwu commented Oct 10, 2021

slf4j is no longer required for compiling JDBC driver, and it's optional in runtime as well.
Note: log message now follows Java standard - see java.util.Formatter

@github-actions
Copy link

Benchmark                           (client)  (connection)  (statement)   Mode  Cnt    Score     Error  Units
Basic.insertOneRandomNumber  clickhouse-jdbc         reuse       normal  thrpt   20  263.170 ±  28.739  ops/s
Basic.insertOneRandomNumber  clickhouse-jdbc         reuse     prepared  thrpt   20  261.297 ±  29.712  ops/s
Basic.insertOneRandomNumber  clickhouse-jdbc           new       normal  thrpt   20  260.962 ±  32.777  ops/s
Basic.insertOneRandomNumber  clickhouse-jdbc           new     prepared  thrpt   20  264.850 ±  30.335  ops/s
Basic.selectOneRandomNumber  clickhouse-jdbc         reuse       normal  thrpt   20  898.757 ± 100.074  ops/s
Basic.selectOneRandomNumber  clickhouse-jdbc         reuse     prepared  thrpt   20  826.811 ± 126.903  ops/s
Basic.selectOneRandomNumber  clickhouse-jdbc           new       normal  thrpt   20  831.540 ±  94.788  ops/s
Basic.selectOneRandomNumber  clickhouse-jdbc           new     prepared  thrpt   20  832.440 ±  90.525  ops/s

@zhicwu zhicwu merged commit e27f576 into ClickHouse:develop Oct 10, 2021
@zhicwu zhicwu deleted the decouple-from-slf4j branch October 10, 2021 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant