Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build break on 21.3 #737

Merged
merged 5 commits into from
Oct 8, 2021
Merged

Fix build break on 21.3 #737

merged 5 commits into from
Oct 8, 2021

Conversation

zhicwu
Copy link
Contributor

@zhicwu zhicwu commented Oct 7, 2021

When use -1 as DateTime/DateTime32 in 21.3, it's interpreted as 2106-02-07 06:28:15 instead of 1970-01-01 00:00:00 like in 21.6+. This pull request will skip the tests in 21.3.

@github-actions
Copy link

github-actions bot commented Oct 7, 2021

Benchmark                           (client)  (connection)  (statement)   Mode  Cnt    Score     Error  Units
Basic.insertOneRandomNumber  clickhouse-jdbc         reuse       normal  thrpt   20  255.318 ±  25.357  ops/s
Basic.insertOneRandomNumber  clickhouse-jdbc         reuse     prepared  thrpt   20  252.608 ±  26.580  ops/s
Basic.insertOneRandomNumber  clickhouse-jdbc           new       normal  thrpt   20  253.445 ±  24.478  ops/s
Basic.insertOneRandomNumber  clickhouse-jdbc           new     prepared  thrpt   20  256.662 ±  26.986  ops/s
Basic.selectOneRandomNumber  clickhouse-jdbc         reuse       normal  thrpt   20  799.962 ± 109.448  ops/s
Basic.selectOneRandomNumber  clickhouse-jdbc         reuse     prepared  thrpt   20  816.660 ±  97.930  ops/s
Basic.selectOneRandomNumber  clickhouse-jdbc           new       normal  thrpt   20  775.584 ±  77.710  ops/s
Basic.selectOneRandomNumber  clickhouse-jdbc           new     prepared  thrpt   20  815.340 ±  71.616  ops/s

@github-actions
Copy link

github-actions bot commented Oct 7, 2021

Benchmark                           (client)  (connection)  (statement)   Mode  Cnt     Score     Error  Units
Basic.insertOneRandomNumber  clickhouse-jdbc         reuse       normal  thrpt   20   278.760 ±  30.654  ops/s
Basic.insertOneRandomNumber  clickhouse-jdbc         reuse     prepared  thrpt   20   277.878 ±  32.650  ops/s
Basic.insertOneRandomNumber  clickhouse-jdbc           new       normal  thrpt   20   268.650 ±  30.941  ops/s
Basic.insertOneRandomNumber  clickhouse-jdbc           new     prepared  thrpt   20   268.982 ±  36.744  ops/s
Basic.selectOneRandomNumber  clickhouse-jdbc         reuse       normal  thrpt   20  1036.488 ± 139.667  ops/s
Basic.selectOneRandomNumber  clickhouse-jdbc         reuse     prepared  thrpt   20  1102.595 ± 118.559  ops/s
Basic.selectOneRandomNumber  clickhouse-jdbc           new       normal  thrpt   20   960.001 ± 117.716  ops/s
Basic.selectOneRandomNumber  clickhouse-jdbc           new     prepared  thrpt   20  1025.917 ± 118.587  ops/s

@github-actions
Copy link

github-actions bot commented Oct 8, 2021

Benchmark                           (client)  (connection)  (statement)   Mode  Cnt    Score    Error  Units
Basic.insertOneRandomNumber  clickhouse-jdbc         reuse       normal  thrpt   20  251.026 ± 24.151  ops/s
Basic.insertOneRandomNumber  clickhouse-jdbc         reuse     prepared  thrpt   20  249.875 ± 25.644  ops/s
Basic.insertOneRandomNumber  clickhouse-jdbc           new       normal  thrpt   20  253.805 ± 35.213  ops/s
Basic.insertOneRandomNumber  clickhouse-jdbc           new     prepared  thrpt   20  248.732 ± 32.132  ops/s
Basic.selectOneRandomNumber  clickhouse-jdbc         reuse       normal  thrpt   20  829.617 ± 82.784  ops/s
Basic.selectOneRandomNumber  clickhouse-jdbc         reuse     prepared  thrpt   20  791.702 ± 77.423  ops/s
Basic.selectOneRandomNumber  clickhouse-jdbc           new       normal  thrpt   20  797.671 ± 55.068  ops/s
Basic.selectOneRandomNumber  clickhouse-jdbc           new     prepared  thrpt   20  767.414 ± 86.194  ops/s

@zhicwu zhicwu merged commit 09b4fb9 into ClickHouse:develop Oct 8, 2021
@zhicwu zhicwu deleted the fix-failure-on-21.3 branch October 8, 2021 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant