Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build script improvements #3087

Open
3 tasks
gingerwizard opened this issue Jan 15, 2025 · 0 comments
Open
3 tasks

Build script improvements #3087

gingerwizard opened this issue Jan 15, 2025 · 0 comments
Labels

Comments

@gingerwizard
Copy link
Contributor

gingerwizard commented Jan 15, 2025

ClickHouse/ClickHouse repo is currently using build in its DocsCheck. This will fail once we enabled docusaurus v3 link checker - as the auto generated settings pages will be missing. It could use new-build (like Vercel) but this has issues (see below)

Our build scripts are alittle disjointed and inconsistent. We have both new-build and build. new-build includes settings generation. build was kept (we believe) so people could do local builds. We need to consolidate. Possible approach:

  • new-build uses copyClickhouseRepoDocs but this clones the ClickHouse repo to copy the reference docs. new-build could accept a path, passing this to copyClickhouseRepoDocs - this could then use prep-from-local.
  • settings generation will need to be its own yarn action - as people will need to do this locally for links to not break. This needs the latest of clickhouse - so it pulls it from a binary. Update docs.
  • prep-from-local should only copy changed files. Maybe we use rsync if installed, otherwise default to current implementation.

Move scripts to single directory and add linter for python and bash.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant