Display CPU Usage progress correctly when <= 0 #38038
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robot-clickhouse
added
the
pr-not-for-changelog
antonio2368
reviewed
Jun 14, 2022
antonio2368
added
the
can be tested
antonio2368
changed the title
Co-authored-by: Antonio Andelic <[email protected]>
|
|
||
| profiling_msg_builder << "("; | ||
| if (cpu_usage <= 0) | ||
| profiling_msg_builder << 0 << " CPU"; |
There was a problem hiding this comment.
It will introduce unwanted jumping effect when two messages
0 CPU
0.1 CPU
will quickly change each other.
It is better to have
0.0 CPU
0.1 CPU
for alignment.
|
I've accidentally made another PR for the same issue: #38064 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fixes #38003. The check has been added to display 0 if CPU_usage is <=0.