Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up truncated grid constructor with next ClimaCore release #1240

Open
ilopezgp opened this issue Jul 22, 2022 · 0 comments
Open

Clean up truncated grid constructor with next ClimaCore release #1240

ilopezgp opened this issue Jul 22, 2022 · 0 comments
Assignees

Comments

@ilopezgp
Copy link
Contributor

PR #1238 introduces an adjusted truncated mesh to substitute the previous implementation we had.

However, there is no need to do this in TC.jl or use TC.Grid objects in the process. The ClimaCore PR 812 implements the same truncated grid as PR #1238 as an internal ClimaCore function that does not use Grids, and requires one less Mesh to be constructed.

Once the dependency of TC on ClimaCore is updated to include the new formulation, the truncated grid in TC should be deleted in favor of the CC one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant