Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use new interface for implicit RRE #528

Closed
Tracked by #135
juliasloan25 opened this issue Feb 28, 2024 · 0 comments · Fixed by #542
Closed
Tracked by #135

use new interface for implicit RRE #528

juliasloan25 opened this issue Feb 28, 2024 · 0 comments · Fixed by #542
Assignees
@juliasloan25
Labels
enhancement New feature or request
Milestone
O2.3.6 Implicit s...

Comments

@juliasloan25
Copy link
Member

juliasloan25 commented Feb 28, 2024 •
edited
Loading

Is your feature request related to a problem? Please describe.
Use the most recent implicit solver interface, as described in CliMA/ClimaCore.jl#1230.

Atmos PR updating to new interface: CliMA/ClimaAtmos.jl#2044

closed by #542

Notes on interface changes

  • majority of changes in ClimaCore MatrixFields
  • ldiv! now in ClimaCore src/Fields.fieldvector.jl
    • can remove from ClimaLand.jl
  • thomas_algorithm now in ClimaCore src/Operators/thomas_algorithm.jl
    • can remove from ClimaLand.jl
  • linsolve not moved to ClimaCore ?

Atmos update

  • struct SchurComplementW -> ImplicitEquationJacobian
  • Operators.Operator2Stencil -> MatrixFields.operator_matrix
  • Wfact! remains
  • ldiv! remains (I thought this was moved to ClimaCore ?)

QA

  • verify RRE experiment results don't change
@juliasloan25 juliasloan25 added the enhancement New feature or request label Feb 28, 2024
@juliasloan25 juliasloan25 self-assigned this Feb 28, 2024
@juliasloan25 juliasloan25 mentioned this issue Feb 28, 2024
Closed
15 tasks
@juliasloan25 juliasloan25 changed the title use new ClimaTimeSteppers interface use new interface for implicit RRE Mar 4, 2024
This was referenced Mar 4, 2024
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@juliasloan25 juliasloan25

Labels
enhancement New feature or request
Projects
None yet
Milestone
O2.3.6 Implicit solver for full soil ...
Development

Successfully merging a pull request may close this issue.

update implicit solver interface CliMA/ClimaLand.jl
1 participant
@juliasloan25