Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ScheduledDiagnostics are not correctly deduplicated #92

Closed
Sbozzolo opened this issue Oct 21, 2024 · 0 comments · Fixed by #93
Closed

ScheduledDiagnostics are not correctly deduplicated #92

Sbozzolo opened this issue Oct 21, 2024 · 0 comments · Fixed by #93
Assignees
Labels
bug Something isn't working

Comments

@Sbozzolo
Copy link
Member

ClimaDiagnostics is supposed to de-deuplicate diagnostics, but this is not always working correctly. The reason for this is that ClimaDiagnostics uses unique to identify duplicates. In turn, unique uses == to determine equality. Since we don't implement == for ScheduledDiagnostics, this defaults to ===, which does not what we want for RefValues.

@Sbozzolo Sbozzolo added the bug Something isn't working label Oct 21, 2024
@Sbozzolo Sbozzolo self-assigned this Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant