Add actual condition to run orchestrate_diagnostics #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@charleskawczynski, what do you think? |
|
Sorry I missed this, I'm in a lot of notification debt. Yeah, this is probably not worth the additional complexity. Let's punt on it for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #37, but I am not sure if it is worth the additional complexity (even if it is not much more complex, it's mostly the fact that now there two callbacks have to be added).
This PR pulls out the condition to run the diagnostic callback from the diagnostic callback, so that
callback.conditionis reflective on whether the diagnostic callback will be run or not. However, the diagnostic callback might be running for compute, output, or sync, and I expect compute to be on almost all iterations, so thatconditionwill not be particularly informative. To make it more useful, we could further split the callbacks to compute, output, cleanup, and sync to provide more granular information on what is schedule to happen.