Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalize atmos_init to dry and no radiation cases #753

Closed
8 tasks done
LenkaNovak opened this issue Apr 24, 2024 · 0 comments · Fixed by #754
Closed
8 tasks done

Generalize atmos_init to dry and no radiation cases #753

LenkaNovak opened this issue Apr 24, 2024 · 0 comments · Fixed by #754
Assignees
Labels
🍃 leaf Issue coupled to a PR

Comments

@LenkaNovak
Copy link
Collaborator

LenkaNovak commented Apr 24, 2024

Currently, we are assuming that we are always running with a radiation and moisture models. As part of #392 we need to be able to relax these assumptions.

Components

  • add hasradiation and hasmoisture functions and update the relevant get_field functions
  • add buildkite driver with conservation checks (but asserts set to softfail due to division by zero for water conservation)
  • move time_to_seconds to user_io/io_helpers.jl, as it is not dependent on cli_options.
  • renmed get_atmos_config to get_atmos_config_dict to differentiate between the config Dict and AtmosConfig objects
  • generalize flux calculation
  • generalize dir_paths so they can be easily manipulated for different experiments
  • update driver

QA

  • ensure energy conservation build
Screen Shot 2024-04-29 at 11 30 02 AM
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍃 leaf Issue coupled to a PR
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant