Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Streamline Slab types #59

Closed
kmdeck opened this issue Jun 17, 2022 · 1 comment
Closed

Streamline Slab types #59

kmdeck opened this issue Jun 17, 2022 · 1 comment

Comments

@kmdeck
Copy link
Member

kmdeck commented Jun 17, 2022

Currently, slab models are used for land (in some cases), sea ice, and ocean. Land can also be a bucket model, and ocean temperatures can also be prescribed. In the future, there will be different sea ice models as well.

  • use multiple dispatch for obtaining T, energy, etc correctly from different models, as they are stored differently in different models
  • make a more useful slab_utils file and separate ocean, land, and ice directories?

Basically, clean up duplicate code between slab models and make use of dispatch over flags for different model types.

@LenkaNovak
Copy link
Collaborator

To be addressed as part of #212

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants