Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace sea ice test with experiment #532

Open
juliasloan25 opened this issue Dec 1, 2023 · 0 comments
Open

replace sea ice test with experiment #532

juliasloan25 opened this issue Dec 1, 2023 · 0 comments
Labels
💰 Grab Bag
Milestone
Software Improvem...

Comments

@juliasloan25
Copy link
Member

juliasloan25 commented Dec 1, 2023 •
edited
Loading

We currently have a test for Eisenman sea ice (eisenman_seaice_tests.jl) which constructs and steps a simulation. This requires functionality from SciMLBase, so that package has to be added to the test/ environment. I suggest that we delete this test, and make sure that the experiment testing Eisenman sea ice makes sufficient checks. This way we can remove timestepping-related dependencies (SciMLBase.jl) from test, while maintaining that this sea ice model is tested.
@juliasloan25 juliasloan25 mentioned this issue Dec 1, 2023
Merged
5 tasks
@juliasloan25 juliasloan25 changed the title move sea ice test to exp/ replace sea ice test with exp/ Dec 2, 2023
@juliasloan25 juliasloan25 changed the title replace sea ice test with exp/ replace sea ice test with exp/ ? Dec 10, 2023
@juliasloan25 juliasloan25 changed the title replace sea ice test with exp/ ? replace sea ice test with experiment Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
💰 Grab Bag
Projects
None yet
Milestone
Software Improvements for ClimaCoupler
Development

No branches or pull requests
2 participants
@LenkaNovak @juliasloan25