Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable q_sfc to be calculated by each surface model #338

Closed
7 tasks done
LenkaNovak opened this issue Jun 27, 2023 · 0 comments · Fixed by #337
Closed
7 tasks done

Enable q_sfc to be calculated by each surface model #338

LenkaNovak opened this issue Jun 27, 2023 · 0 comments · Fixed by #337
Assignees
Labels
🍃 leaf Issue coupled to a PR

Comments

@LenkaNovak
Copy link
Collaborator

LenkaNovak commented Jun 27, 2023

Necessary to be able to use Bucket's q_sfc, which takes into account its internal values of snow and bare soil are fractions. Here enable this, and apply the same procedure for the other surfaces.

Major changes

  • coupler can calculate rho_sfc
  • all surface models will be able to hold their own rho_sfc and calculate their own q_sfc (including the Stubs)
  • correct specification of Ice() when calculating q_vap_saturation_generic (before only Liquid() was enabled)
  • initial conditions are re-specified to be more consistent with atmos, enabling more stable runs

To do

  • enable coupler to calculate rho_sfc based on surface and atmos states
  • add calculation of q_sfc to the remaining component models
  • set the new q_sfc in the compute_atmos_turbulent_fluxes! function
  • resolve grid imprinting problem when calling q_sfc from land - due to atmos init conditions being too abrupt
    • modified surface initial conditions to be more consistent with the new atmos conditions
    • ensure and document the correct order of field exchange initialization
  • resolve why nondeterministic ci runs - atmos now has a random initial perturbation
  • add tests for new src functions

QA

  • ensure tests are passing (physical, conservation, performance)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍃 leaf Issue coupled to a PR
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant