Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for HDF5 read and write with PointSpaces #2162

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

imreddyTeja
Copy link
Contributor

@imreddyTeja imreddyTeja commented Jan 27, 2025

write! on Fields is now dispatched off the input
field's space. When it is a point space, the local
geometry data is written. When read_field is called,
and no grid is present, then the field is assumed
to be on a point space.

Closes #2171

  • Code follows the style guidelines OR N/A.
  • Unit tests are included OR N/A.
  • Code is exercised in an integration test OR N/A.
  • Documentation has been added/updated OR N/A.

@Sbozzolo
Copy link
Member

If we can write, we should also be able to read, so maybe there's some other changes needed here

`write!` on Fields is now dispatched off the input
field's space. When it is a point space, the local
geometry data is written. When read_field is called,
and no grid is present, then the field is assumed
to be on a point space.
@imreddyTeja imreddyTeja force-pushed the tr/support-atmos-single-column branch from 4bdb17a to f97ab1e Compare February 4, 2025 01:06
@imreddyTeja imreddyTeja changed the title Add support for write! with PointSpaces Add support for HDF5 read and write with PointSpaces Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

InputOutput does not support PointSpaces
2 participants