Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add finite difference operator unit tests #2089

Open
charleskawczynski opened this issue Nov 20, 2024 · 1 comment · Fixed by #2148
Open

Add finite difference operator unit tests #2089

charleskawczynski opened this issue Nov 20, 2024 · 1 comment · Fixed by #2148
Assignees
@charleskawczynski
Labels
Correctness ✏️ enhancement New feature or request tests

Comments

@charleskawczynski
Copy link
Member

We should really add unit tests for our finite difference operators (i.e., Operators.getidex for our operators). We can do this using LazyBroadcast, and we can test that the stencil is correct at the index level.
@charleskawczynski charleskawczynski added the enhancement New feature or request label Nov 20, 2024
@charleskawczynski charleskawczynski self-assigned this Nov 20, 2024
@charleskawczynski charleskawczynski mentioned this issue Jan 21, 2025
Merged
@charleskawczynski
Copy link
Member Author

#2148 did not add FD unit tests, this issue was only mentioned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@charleskawczynski charleskawczynski

Labels
Correctness ✏️ enhancement New feature or request tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix getidx for GradientC2F with SetValue bcs CliMA/ClimaCore.jl
1 participant
@charleskawczynski