column
on grids are inconsistent and do not actually make views
#1766
Labels
bug
Something isn't working
column
on grids are inconsistent and do not actually make views
#1766
#1487 fixed some issues, but
column
does not actually make a view, so the underlying DataLayout for aVIJFH
-backed ExtrudedFiniteDifferenceSpace is still aVIJFH
DataLayout.The issue here is that
column
on a broadcasted object now contains a mixture ofVF
andVIJFH
datalayouts. Memory access patterns for our metric terms are now "stuck" to those governed byVIJFH
. i.e., we cannot make MArray-backed datalayouts.This is a hard block, stopping #1763 because we cannot make an MArray-backed
VIJFH
(as that would be huge), and we cannot reconstructExtrudedFiniteDifferenceGrid
on the GPU, since it is mutable.What we have now seems like a bad design in that I would expect
column
to recurse all the way down a broadcasted object, and it doesn't. It's also unfortunate that this is blocking #1763.The same is probably true for
slab
.The text was updated successfully, but these errors were encountered: