Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AxisTensor components from Int to Float #1460

Closed
Sbozzolo opened this issue Sep 14, 2023 · 1 comment
Closed

AxisTensor components from Int to Float #1460

Sbozzolo opened this issue Sep 14, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@Sbozzolo
Copy link
Member

Sbozzolo commented Sep 14, 2023

ClimaAtmos comes with this note/code:

# In order to specify C2F operator boundary conditions with 0 instead of FT(0),
# we need to tell ClimaCore how to convert AxisTensor components from Int to FT.
# TODO: Move this monkey patch to ClimaCore in the next release.
using ClimaCore.Geometry: AxisTensor, components
AxisTensor{T′, N, A, S′}(a::AxisTensor{T, N, A, S}) where {T, N, A, S, T′, S′} =
    AxisTensor(axes(a), S′(components(a)))
Base.convert(::Type{AT}, a::AxisTensor) where {AT <: AxisTensor} = AT(a)

I don't understand it, but it seems to imply that something should be done on the ClimaCore side.

@Sbozzolo Sbozzolo added the bug Something isn't working label Sep 14, 2023
@charleskawczynski
Copy link
Member

This was fixed/removed from ClimaAtmos (I'm not sure when, but I don't see it anymore).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants