Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for reduce-like operations over columns #1095

Closed
charleskawczynski opened this issue Jan 11, 2023 · 2 comments
Closed

Add support for reduce-like operations over columns #1095

charleskawczynski opened this issue Jan 11, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@charleskawczynski
Copy link
Member

The ClimaAtmos gravity wave parameterization requires reduce-like operations over columns. See

argmin

Example here

more functions

We really need to add support for these pieces before this pattern spreads because it:

  • is gpu-incompatible
  • introduces risks in the form of bugs (unprotected getindex calls with Int / PlusHalf)
  • and does not consistently handle topography with the rest of the ClimaCore infrastructure (metric terms are not accounted for when using parent)
@charleskawczynski charleskawczynski added the enhancement New feature or request label Jan 11, 2023
@charleskawczynski
Copy link
Member Author

@dennisYatunin , should we close this?

@dennisYatunin
Copy link
Member

Yup, this was closed by #1903 (and the ClimaAtmos changes were in CliMA/ClimaAtmos.jl#3226).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants