Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure restart works correctly #2604

Closed
szy21 opened this issue Jan 29, 2024 · 3 comments · Fixed by #3396
Closed

Make sure restart works correctly #2604

szy21 opened this issue Jan 29, 2024 · 3 comments · Fixed by #3396

Comments

@szy21
Copy link
Member

szy21 commented Jan 29, 2024

We should make sure the simulation results are identical when running from a restart file and when running from a cold start (freshly). It would be good if we can add a test for this in ci. cc @charleskawczynski

Some thoughts from @Sbozzolo :

  • How are the new callback initialized? For example, if you have a callback called every N/dt, does it pick up from the old ones has left or is a new counter?
  • We have to test MPI/GPU cases as well
  • What happens when you change settings across restarts?
  • Accmulated diagnostics will not work across restarts
  • Progress log will probably be off across restarts
  • Where are restart/output files saved? If we use the ActiveLink style and keep restart_dir = .../output_active, we will need to be careful because the base dir associated to output_active changes with the new simulation.
@Sbozzolo
Copy link
Member

We should also think about what we want to do for the output. Should output from different restarts be in the same folder? Should we append NetCDF files and make very large files? Should we split into different folders?

@Sbozzolo
Copy link
Member

Accumulated diagnostics are not saved in the HDF5 file, so we should think on what to do for them.

@Sbozzolo
Copy link
Member

This has largely been implemented and verified, with some caveats (e.g., diagnostics having to line up with checkpoints)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants