add constant detrainment option #2209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szy21
force-pushed
the
zs/constant_detr
branch
from
f7e6cd3 to
e1d8983
Compare
|
Here is bomex with constant entrainment and detrainment with a timescale of 900s. |
szy21
force-pushed
the
zs/constant_detr
branch
from
f18747e to
7e7239c
Compare
|
I'm going to merge this in as I would like to use it for some other tests. I didn't change any of the current EDMFX configurations. |
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Oct 10, 2023
2209: add constant detrainment option r=szy21 a=szy21 Co-authored-by: Zhaoyi Shen <[email protected]>
|
Build failed: |
|
bors r+ |
|
Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Adds constant timescale detrainment, as suggested by Tapio. I tried running bomex with constant timescale entrainment and detrainment with the same time scale, and the results look terrible (see comments), so I didn't change the configuration file in the end. But this option is still good to have for testing as it is the simplest detrainment closure.
To-do
Content