Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The interpretation of § 128(1) is not entirely correct. #7

Open
ghost opened this issue Mar 28, 2019 · 3 comments
Open

The interpretation of § 128(1) is not entirely correct. #7

ghost opened this issue Mar 28, 2019 · 3 comments

Comments

@ghost
Copy link

ghost commented Mar 28, 2019

มาตรา ๑๒๘
(๑) นําคะแนนรวมทั้งประเทศที่พรรคการเมืองทุกพรรคที่ส่งผู้สมัครแบบบัญชีรายชื่อได้รับ
จากการเลือกตั้งแบบแบ่งเขตเลือกตั้งหารด้วยห้าร้อยอันเป็นจํานวนสมาชิกทั้งหมดของสภาผู้แทนราษฎร

Hence, getAllValidScores should only include party.voteCount only when party.partyListMemberCount && party.partyListMemberCount>0

const getAllValidScores = (parties: IParty[]) =>
parties.reduce((result, party) => {
return result + party.voteCount
}, 0)

@ghost
Copy link
Author

ghost commented Mar 28, 2019

And anyone understand (6): 'ให้นําค่าเฉลี่ยคะแนนของแต่ละพรรคการเมืองต่อจํานวนสมาชิกสภาผู้แทนราษฎรที่พึงมีหนึ่งคนมาพิจารณา ' .. is that average value the same for all parties????

p.repCeiling = p.voteCount / score4Rep

Now (6) suggests to do this ... p.voteCount/p.repCeiling ... that is score4Rep, right? And that should be the same for all parties, right? Do I miss something?

@PanJ
Copy link
Member

PanJ commented Mar 28, 2019

I think you meant partyListCandidateCount > 0 instead of partyListMemberCount > 0 but I got your point. I would be great if you can create PR on the test case that will be failed on the current version.

About (6) please create a separate issue for further discussion :)

@ghost
Copy link
Author

ghost commented Mar 28, 2019

'I would be great if you can create PR on the test case that will be failed on the current version.' --> you mean if I could fix the issue and create a pull request to the master? If so, then of course I can. As I said I am totally new to contributing to github, I just want to be sure ;)
Can you assign the issue to me? I will fix / and add test for it.

Regarding (6), indeed, I will create a separate issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant