-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release core v7.0.3 SDK-4163 #701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* task(MC-2360): Add normalized event and property names evaluation
* chore(MC-1987): Update HTML template for In-Apps preview
- initialises singleton clevertap instance in application class - uses singleton ct instance in whole app
Applies fix for new lines and special js symbols
* feat(SDK-4183): Event properties normalisation - backend sends normalised event properties, we need to compare on sdk side based on normalised event which client app might fire * feat(SDK-4183): Charged event product props normalisation - normalises product item prop keys * chore(SDK-4183): reformatting * test(SDK-4183): adds test to check normalisation * test(SDK-4183): adds test to check normalisation in non charged events
* feat(SDK-4183): changes normalisation to follow LP logic - makes changes to event names and properties and also to charged event logic - tries exact name match first - tries match with normalised event name - tries match after normalising both event name/property and triggers we get from BE * tests(SDK-4183): adds test cases for nomalisation logic - adds for both charged and normal events.
* feat(SDK-4183): updates docs for core SDK release 7.0.3 * feat(SDK-4163): updates the release date - changes title from bug fixes -> new features * feat(SDK-4163): updates the release date in changelog
CTLalit
requested review from
Anush-Shand,
piyush-kukadiya,
darshanclevertap and
vasct
November 29, 2024 12:25
vasct
approved these changes
Nov 29, 2024
piyush-kukadiya
approved these changes
Nov 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://wizrocket.atlassian.net/browse/SDK-4163