Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix cellphone #78537

Merged
merged 1 commit into from
Dec 13, 2024
Merged

fix cellphone #78537

merged 1 commit into from
Dec 13, 2024

Conversation

PatrikLundell
Copy link
Contributor

Summary

None

Purpose of change

Fix #78535, i.e. game crashing on cell phone toggling.

Describe the solution

Add link action to the active cell phone as well, as the crash happens when checking for the existence of link data, but then failing to find a link action.

Describe alternatives you've considered

Change the code to verify link action is also available in order to process link data. However, it makes sense that you should be able to plug it in regardless of whether it's on or off, and there might be other things that actually shouldn't be possible to plug in during use.

Testing

Loading the save provided by @moxian, (since the bug report itself didn't bother to provide one) and then turning the cell phone on and off until the battery ran out. Activated the plug in action once while the phone was on, but didn't actually plug it in anywhere (my action aborted the process).

Additional context

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON <Bugfix> This is a fix for a bug (or closes open issue) astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Dec 13, 2024
@moxian
Copy link
Contributor

moxian commented Dec 13, 2024

I mentioned it in the issue in passing, and this is definitely out of scope of the current PR, but perhaps we should add some consistency checks to the link_up / transform actions so that this sort of bug can be caught at PR time rather than play time.

Yes, there might be some things that shouldn't be plugged during use, but as it stands, having those things is grounds for a segfault, soo... But I guess that would need C++ changes either way...

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Dec 13, 2024
@Night-Pryanik Night-Pryanik merged commit 791bd3f into CleverRaven:master Dec 13, 2024
20 of 25 checks passed
@PatrikLundell PatrikLundell deleted the cell branch December 13, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Turn On Cellphone To > Crash
3 participants