Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unarmed crafting organization #62564

Merged

Conversation

Termineitor244
Copy link
Contributor

Summary

Interface "Creates a new subcategory for unarmed weapons crafting"

Purpose of change

One comment of #61682 reminded me that unarmed weapons (armor) do not have their own subcategory for ease of finding, most are in the bashing department, one is in stabbing and another one is all the way until armor/hands...

So, if you want to craft a weapon (armor) for unarmed combat, you have to search among different crafting lists and read the descriptions to try and guess which weapon is an unarmed weapon or not.

Describe the solution

A new crafting subcategory for weapons, "UNARMED" where you can find all kinds of knuckles, the cestus, the studded gloves and any future unarmed weapon/armor that could be added.

Describe alternatives you've considered

To make it a new subcategory of armor crafting, but these things will be searched as weapons first.

Testing

Started the game, opened the crafting menu, the items are under a new header; "unarmed".

Additional context

imagen

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Items: Armor / Clothing Armor and clothing Info / User Interface Game - player communication, menus, etc. astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Dec 4, 2022
@Dan1ss1mo
Copy link
Contributor

i think adding sabatons, demi gauntlets and mittenn gauntlets here would also be reasonable, can item be in 2 categories at the same time though?

@Termineitor244
Copy link
Contributor Author

A good idea, but as you say I don't think its possible to add a recipe to 2 categories, I will try when I arrive at home, but if not then this would probably need some c++ changes to work.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 9, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not bump or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

@github-actions github-actions bot added the stale Closed for lack of activity, but still valid. label Jan 9, 2023
@Maleclypse Maleclypse added 0.G String Freeze and removed stale Closed for lack of activity, but still valid. labels Jan 24, 2023
Copy link
Contributor

@bombasticSlacks bombasticSlacks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this PR be rearranged to not move the items to new files? It makes it harder to track the GIT history.

@Termineitor244
Copy link
Contributor Author

Of course! I considered a petition like this when making the PR so I just have to revert the last commit, which only created and moved the items to the new file.

I will do it when I arrive at home after work today.

@bombasticSlacks bombasticSlacks merged commit 799e0b1 into CleverRaven:master Mar 5, 2023
@AcidAntOnAMinefield
Copy link

Absolutely legendary PR. Thank you!

@Termineitor244 Termineitor244 deleted the Unarmed-organization branch March 5, 2023 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Info / User Interface Game - player communication, menus, etc. Items: Armor / Clothing Armor and clothing [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants