From a7a706e864894ceeec45606274a6e8b2f21ec4af Mon Sep 17 00:00:00 2001 From: EI IKaO <109350502+EIIKaO@users.noreply.github.com> Date: Thu, 22 Sep 2022 03:03:16 +0900 Subject: [PATCH 1/2] Added elements which monster_attack.py missed - Add elements, "miss_msg_u" and "miss_msg_npc" --- lang/string_extractor/parsers/monster_attack.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lang/string_extractor/parsers/monster_attack.py b/lang/string_extractor/parsers/monster_attack.py index 1682870d6b48e..e40a30bbc93b7 100644 --- a/lang/string_extractor/parsers/monster_attack.py +++ b/lang/string_extractor/parsers/monster_attack.py @@ -2,6 +2,6 @@ def parse_monster_attack(json, origin): - for key in ["hit_dmg_u", "hit_dmg_npc", "no_dmg_msg_u", "no_dmg_msg_npc"]: + for key in ["hit_dmg_u", "hit_dmg_npc", "miss_msg_u", "miss_msg_npc", "no_dmg_msg_u", "no_dmg_msg_npc"]: if key in json: write_text(json[key], origin, comment="Monster attack message") From 1e58655dd7f1e2a42f7323ff172fd14cfe5d264a Mon Sep 17 00:00:00 2001 From: EI IKaO <109350502+EIIKaO@users.noreply.github.com> Date: Thu, 22 Sep 2022 03:38:50 +0900 Subject: [PATCH 2/2] Optimize to Flake8 --- lang/string_extractor/parsers/monster_attack.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lang/string_extractor/parsers/monster_attack.py b/lang/string_extractor/parsers/monster_attack.py index e40a30bbc93b7..103e52700607a 100644 --- a/lang/string_extractor/parsers/monster_attack.py +++ b/lang/string_extractor/parsers/monster_attack.py @@ -2,6 +2,7 @@ def parse_monster_attack(json, origin): - for key in ["hit_dmg_u", "hit_dmg_npc", "miss_msg_u", "miss_msg_npc", "no_dmg_msg_u", "no_dmg_msg_npc"]: + for key in ["hit_dmg_u", "hit_dmg_npc", "miss_msg_u", "miss_msg_npc", + "no_dmg_msg_u", "no_dmg_msg_npc"]: if key in json: write_text(json[key], origin, comment="Monster attack message")