Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two houses at the end of a lonely road #54022

Merged
merged 42 commits into from
Jan 14, 2022

Conversation

bombasticSlacks
Copy link
Contributor

@bombasticSlacks bombasticSlacks commented Jan 4, 2022

Summary

Content "Added new faction isolated artisans"

Purpose of change

There is a desire to have competent experts exist in the world so that they can help with large projects, trade useful and sensible materials and equipment, give quests and direct the player to interesting things.

As well more competent experts means who the player sides with and works with will matter more. Not everyone can make everything and their are only so many things to go around. For a direct example, though I don't think it will make it in this first pass, one of the NPC's from this faction will want the player to find a specific set of plans as part of a quest. The player is going to instead be able to give the plans to Hub 01 for an entirely different outcome.

Describe the solution

Create a new small faction called isolated artisans

Implemented a new small overmap called isolated road. It consists of two rustic houses, a pile of traps/defenses and two NPCs

The NPC's are:
Jay Ruckers - a tech bro type, who worked for a weapons manufacturer. He's convinced that bullets are the new gold standard of currency and wants to become the new controller of that currency. He will trade the player for ammo and perhaps at later levels of trust gun mods, magazines. To begin he will sell standard ammunition and also print his own currency (selling reloaded ammo). Either in the future Jay will be able to attach mods to your guns for a fee.

Jay in this PR does

  • Sells ammo
  • Sells reloaded ammo
  • converts your currency taking an ammo of a given type and making rounds of another. This is a massive amount of JSON in its own file. The ratios for this are based on the in game amounts of powder each round takes. Jay does a direct conversion - 10% (as a fee). The ratios are at the bottom of this PR. Jay will exchange 200 rounds if you wait a day and 800 rounds if you wait 5 days.
  • Gives one quest to find a data drive in a house with an additional surprise.

Cody Miller - a kind older engineer who worked as a consultant before the cataclysm. Bored with her day to day Cody was a member of the SCA and an ancient arms and armor enthusiast. She acts as a merchant selling a small amount of medieval arms and armor, accessories for those things, well made bolts and arrows and a few xbows/bows all that she makes her self (or has lying around as collectors items). Cody's big thing will be she has a very small inventory for sale at any given time and also doesn't carry any spare currency. She'll take money if you offer it but isn't interested in hoarding cash. She also will let you use her impressive workshop of tools and equipment as long as you buy a co-op membership from her making you a shared member of the workshop.

Cody in this PR does

  • Sells armor
  • Sells manuals
  • Offers access to her fabrication shop for 100 merch
  • Sells weapons
  • Gives a quest to find a new location a Gun Show

The two will live on this reinforced property but just as the cataclysm really started going and they had secured their property they got into a fight. So the initial quest chain will be helping each of them do something kind for the other as an apology.

The two initial quests are:
From Cody - Jay was talking about going to a gun show before the cataclysm hit. He said someone there had managed to smuggle a Military grade Russian rifle into the country and was going to get to take a look. It's a long shot but your gonna check if it was there. [ New location, New enemy, Unique Rifle KORD 6P67].

  • Reveals the gun show on your map
  • There will be an KORD there

From Jay - Cody was looking for the software to read new encrypted weapon manufacturing specs. Need to find her some debug software to decrypt nanofabricator disks.

  • Reveals a generic house with a surprise in the garage
  • Rewards 200 5.45 ap rounds and a 60 round 5.45 mag

after this the two will be back on friendly terms and will start collaborating. That will lead to further missions from each and them working on weird weapons and project together outside the scope of this first PR

Additional Stuff This PR Adds:

  • New UGV type the UGV Liberty Edition. Has a fireworks cannon and talks about being a patriot
  • Location Gun Show, has a bunch of gun stuff, UGVs, and the new liberty UGVs
  • KORD 6P67 a slightly better AK74 with a pile of mods including a unique mod to simulate the Russian firearm balanced recoil system. (Picture of it at the bottom of this PR)
  • AK74 Casket mag. Only location is as a reward for completing the quest. It's a 60 rounder.
  • Cody's Forge An item in Cody's shop to future proof for the steel rework that is currently ongoing.

ALL DONE

  • Dialogue for them
  • Quest 1
  • Quest 2
  • Cody's workshop basement mapgen
  • Refine item lists
  • Set up trade lists
  • Probably some other stuff
  • mapgen polish

Describe alternatives you've considered

Testing

I've ran through it a few times but it needs a lot of testing for every possible situation.

Additional context

Conversion Values in % for bullets (10% fee included)
image

The KORD
image

@Maleclypse Maleclypse added Map / Mapgen Overmap, Mapgen, Map extras, Map display NPC / Factions NPCs, AI, Speech, Factions, Ownership Missions Quests and missions labels Jan 4, 2022
@github-actions github-actions bot added the astyled astyled PR, label is assigned by github actions label Jan 4, 2022
@gkarfakis19
Copy link
Contributor

This sounds absolutely terrific! I'm happy to see such unique and fun NPCs implemented into the game, as they serve as a perfect excuse for the player to acquire some exotic, rare gear such as Russian 5.45 or 7.62 rifles/ammo and medieval weaponry.

@PatrikLundell
Copy link
Contributor

It seems these characters would be suitable for providing custom job services, so you'd be able to commission the construction of items that aren't in their current inventories.
Obviously not the first thing to implement, but hopefully a target for further development.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 4, 2022

This is an automated message. Please kindly disregard if you think this is inaccurate.

Automatic spell checking encountered unrecognized words in the following text:

  • The artisans became a corner stone of the survivor community and economy.  Cody's **infectuous** desire for sharing helped bridge gaps with other groups and Jays 'banking' service became crucial to maintaining security.
    

@github-actions
Copy link
Contributor

github-actions bot commented Jan 9, 2022

This is an automated message. Please kindly disregard if you think this is inaccurate.

Automatic spell checking encountered unrecognized words in the following text:

  • I'd be careful there Jay was saying they were bringing some new automomous hardware to the show.

@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Jan 10, 2022
@kevingranade
Copy link
Member

Little note, if Jay knows what he's doing and has access to good tools and materials, there's no reason to limit him to producing what we call reloaded rounds, we are planning on making that available to the player as well with some extra complications, but as you're handling it in dialogue logic already you can skip straight to the payoff.

@bombasticSlacks
Copy link
Contributor Author

bombasticSlacks commented Jan 11, 2022

Little note, if Jay knows what he's doing and has access to good tools and materials, there's no reason to limit him to producing what we call reloaded rounds, we are planning on making that available to the player as well with some extra complications, but as you're handling it in dialogue logic already you can skip straight to the payoff.

yeah I didn't want to make a furniture piece for it like a "hand loaders bench" since I'm not an expert in handloads and it seems like a conversation in and of itself to add that and make recipes. But in Jays case that's why I based the round conversion off powder values. It's not mentioned directly in the PR but in my mind Jays got a bunch of bullet stashes buried in fields and anything he doesn't have loaded he'd have the brass to pull from the rounds you give him to make. Which is why he has the standardized wait times. I know the conversion json file is a bit of a labyrinth but the output are standard grade rounds not reloaded.

@bombasticSlacks bombasticSlacks changed the title [WIP]Two houses at the end of a lonely road Two houses at the end of a lonely road Jan 13, 2022
@bombasticSlacks
Copy link
Contributor Author

bombasticSlacks commented Jan 13, 2022

I forgot to remove the WIP from the title but this is ready to merge, unless someone else spots issues, currently.

@github-actions github-actions bot removed the json-styled JSON lint passed, label assigned by github actions label Jan 13, 2022
@github-actions github-actions bot removed the BasicBuildPassed This PR builds correctly, label assigned by github actions label Jan 13, 2022
@github-actions github-actions bot added the json-styled JSON lint passed, label assigned by github actions label Jan 13, 2022
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Jan 13, 2022
@kevingranade kevingranade merged commit 7c60531 into CleverRaven:master Jan 14, 2022
@NetSysFire NetSysFire added the [JSON] Changes (can be) made in JSON label Jan 14, 2022
@Faalagorn
Copy link
Contributor

I left some notes on Transifex and Discord, but posting it here for posterity as well; I may eventually make some PR if time permits, but when translating the game to Polish I found that there's some writing errors, in particular with Cody's and Jay's dialogues (missing commas, apostrophes, casing errors, and not all of them are from the way they speak).

@tenmillimaster
Copy link
Member

I think it would be much more believable if the Kord was not a Kord but any other BARS action AK (a Kalashnikov SR-1 or Saiga MK 107, or I suppose one of the FA variants) that's been chopped up out of country, imported into the US and rebuilt. Acquiring a limited production russian SF gun, then smuggling it into the country seems very farfetched compared to the common practice of rebuilding almost-correct (no full-auto) parts kit guns. For those unware, this is a very common practice to get guns in the US - chop up the receiver in 3 pieces, throw away the barrel, then import the parts and rebuild the gun as a semi-auto gun. For rare guns the practice is common - see the CETME-L marcolmar builds or T36 builds by tommy built tactical. For unobtainium guns it's still possible - Someone has cloned an AK-5 before https://www.acrforum.com/threads/the-ak5-build-project.7657.

For determined collectors, it's better to have 90% of the gun and remain legal than it is to risk life and limb (and criminality) by smuggling in a gun like this.

The issue of the resultant gun not being full-auto also wouldn't really a gameplay issue either if this change was made. It would not be unreasonable for a skilled artisan (cody) to install the appropriate disconnector. Once you get the gun back from them, you've got your "Kord 6p67" without the backstory that we have so often before rejected.

@bombasticSlacks
Copy link
Contributor Author

Feel free to make what ever changes you deem necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Map / Mapgen Overmap, Mapgen, Map extras, Map display Missions Quests and missions NPC / Factions NPCs, AI, Speech, Factions, Ownership
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants