Consistent UPS charge consumption when crafting

[RoyBerube]

Summary

SUMMARY: Bugfixes "Consistent UPS charge consumption when crafting"

Purpose of change

Fixes #45330
Fixes #43054

Describe the solution

Multiple problems had to be addressed to fix this bug.

• Tools used for crafting items could be only on the map or in inventory, but not both. Since UPS power and the tool could be in both locations, this was a main source of the problem. Fixed by allowing crafting tools to span the map and players inventory if needed.
• Some code was detecting items on the map while it was only consuming from inventory, causing inconsistencies. This has been fixed by allowing radius to force player inventory only.
• Power consumption of tools on the map were not accounting for UPS. This has been fixed.

Describe alternatives you've considered

Testing

Full test program: no problems.

Tested crafting with arc welders and UPS in all possible combinations on the map and in inventory. Power consumption is consistent and reliable.

Tested stopping of craft, moving tools, and resuming. In certain situations such as moving tools from inventory to the map it will give a warning message message of missing charges and stop, but will resume correctly with a prompt for tool selection if the craft is attempted again. Power consumption is correct however and is only a minor inconvenience in a rare circumstance. To eliminate the message would require - in my opinion - prompting the player about tool usage with every resumption of a craft. This way is less intrusive.

Additional context

[Raikiri]

Is this related? #45018

[Raikiri]

I was playtesting these changes. Looks like it's significantly better than before, I can almost always use UPS reliably, but it still does not work with kiln and forge that have a UPS mod.

[RoyBerube]

@Raikiri Oh well, one more thing to add to the TODO pile. Those tools must be getting handled differently, or they would have been fixed along with the rest.

[Raikiri]

@RoyBerube actually after further testing it still happens to all tools, but more rarely. I can't give you a repro case, but I noticed that sometimes I start a craft using an integrated toolset CBM for soldering and then it says "You no longer have a none and can't continue crafting" when it runs out of bionic charges charges even though I have a UPS'd soldering iron nearby.

Also with forge and kiln I sometimes have to pick them up, drop them, pick up UPS, just shuffle them around for a bit in order to make them detect each other (?). Sorry I can't give you a more reliable repro, but looks like there's still edge cases left.

Looks like in the crafting menu it detects tools and charges correctly, but then sometimes fails during crafting.