Imbue scent map (de)serialization stream with the C locale #44659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can confirm that this fixes the issue on my system. |
I-am-Erk
added
[C++]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Bugfixes "Fix scent map saved with invalid utf8 sequence"
Purpose of change
Fixes #44608.
Describe the solution
Imbue scent map (de)serialization stream with the C locale to avoid writing the thousands separator.
Testing
Tested with two saves and scent values were correctly loaded. My machine doesn't use a locale with thousands separator though, so I cannot test that.
Additional context
This does not fix already broken saves. Since "grscent" is only saved in a single place (the
.savfile), people with a broken save can just edit the file to remove the thousands separator.