Skimming through book's contents won't show skill progress indicator #37800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Night-Pryanik
added
the
Info / User Interface
ifreund
added
<Bugfix>
Night-Pryanik
deleted the
skimming-book-doesn't-show-skill-increase-indicator
branch
This was referenced Feb 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Interface "Skimming through book's contents won't show skill progress indicator."Purpose of change
Closes #36490 - Skill progression indicator appears when skimming books.
Describe the solution
reading: skill_name 0 -> 1 (0%)progress indicator will be shown only for already identified books. Unidentified books will show genericreadingindicator.Describe alternatives you've considered
None.
Testing
Debug-set 2 to electronics. Spawned
What's a transistor?.Read it to skim. Observed "reading" indicator.Read it again. Observed "reading: electronics 2 -> 3 (x%)" indicator.Additional context
None.