Remove "dig a pit" option from construction list

[RedShakespeare]

Summary

SUMMARY: Bugfixes "Remove 'dig a pit' option from construction list"

Purpose of change

Fixed #33618 - Different mining byproducts

Describe the solution

Deleted the "dig a pit" options from "*" list since it had already been moved to the activation lists of digging tools, which could work well.

Describe alternatives you've considered

Add byproducts to the digging constructions (but since cutting trees had also been removed for the same reason there's no need to do extra work)

[anothersimulacrum]

Isn't this necessary for calculating faction camp expansion requirements?

[RedShakespeare]

It's the digging mechanism that influence this, not the digging options, if I didn't get it wrong.

Cutting down trees also matters when it comes to camps but it has been out of the construction list for quite a long time,isn't it?

[anothersimulacrum]

I'm talking about the blueprint_autocalc added in #31115

add support for basecamps being able to autocalculate their upgrade build time and requirements. For that to happen, all common terrain constructions need to have a construction definition, but some constructions, like deep and shallow pits, are not meant to be selectable by the user. add the concept of a hidden construction, and add definitions for the shallow pit and deep pit construction.

So the issue is probably this showing up more than it existing.

[RedShakespeare]

Ah...sorry, I got it. Thank you.
So maybe these options should be hidden instead?
Current digging options don't provide byproducts and may confuse the players.

[anothersimulacrum]

Okay, the relevant PR is actually #31209
Looks like "on_display": false isn't working properly.

[RedShakespeare]

Yes...failed to notice that problem had been solved in latest versions(since the issue was raised yesterday). My bad..