Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename map::getglobal() to map::get_abs() #79118

Closed
PatrikLundell opened this issue Jan 12, 2025 · 0 comments · Fixed by #79167
Closed

Rename map::getglobal() to map::get_abs() #79118

PatrikLundell opened this issue Jan 12, 2025 · 0 comments · Fixed by #79167
Labels
<Suggestion / Discussion> Talk it out before implementing

Comments

@PatrikLundell
Copy link
Contributor

PatrikLundell commented Jan 12, 2025

Is your feature request related to a problem? Please describe.

This request deals with code only, and has no impact on game play.

Classes have rather varying names for getting absolute positions, and while they used to have varying names for getting untyped bubble positions, typification has largely resulted in a reasonably common pos_bub(). This is messy and somewhat hard to keep track of.

Solution you would like.

I would like to see a standardization of pos_bub() and pos_abs(), starting with the map operations.

Describe alternatives you have considered.

  • I could make a PR and see if it's accepted, but thought a suggestion and potential discussion would be better, and then produce a PR after that if the request seems to be accepted.
  • We could also keep the current names, as they're not broken from a technical point of view, and some people will probably struggle to relearn the operation names. Others, like myself, would probably continue to struggle to find out what the name is for this class (and if there is such an operation at all, since a lot of classes have little to no need for it (and there's always the work around of converting the bubble coordinate to a global one via the reality bubble map).
  • Go through classes and change these operations in one fell swoop.

Additional context

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Suggestion / Discussion> Talk it out before implementing
Projects
None yet
1 participant