Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oxyacetylene (id) and acetylene have the same name: acetylene #74252

Closed
Brambor opened this issue Jun 2, 2024 · 4 comments · Fixed by #74325
Closed

oxyacetylene (id) and acetylene have the same name: acetylene #74252

Brambor opened this issue Jun 2, 2024 · 4 comments · Fixed by #74325
Labels
(S2 - Confirmed) Bug that's been confirmed to exist

Comments

@Brambor
Copy link
Contributor

Brambor commented Jun 2, 2024

Describe the bug

Looking through the crafting menu there are two distinct items with the name acetylene. It is very confusing:

image

Looking through the code, there they are:

  {
    "id": "acetylene",
    "type": "COMESTIBLE",
    "name": { "str_sp": "acetylene" },
    "category": "chems",
    "description": "A flammable gas that explodes under pressure.  Combined with oxygen, acetylene makes a great welding gas.",
    "comestible_type": "INVALID",
    "weight": "40 g",
    "volume": "250 ml",
    "price": "12 USD",
    "price_postapoc": "2 USD 50 cent",
    "material": [ "hydrocarbons" ],
    "symbol": "=",
    "color": "red",
    "charges": 1,
    "stack_size": 100,
    "phase": "liquid",
    "explode_in_fire": true,
    "explosion": { "power": 20, "shrapnel": 0 },
    "flags": [ "NO_DROP", "IRREMOVABLE" ]
  },
  {
    "//": "roughly 35grams of acetylene per cubic foot at STP. Volume given is when compressed - B tank has 9.17 L tank and holds 40 cubic feet.",
    "id": "oxyacetylene",
    "type": "AMMO",
    "name": { "str_sp": "acetylene" },
    "description": "Pressurized, dangerous acetylene gas.  Can be used for welding or cutting with a torch.",
    "weight": "1 g",
    "volume": "250 ml",
    "price": "24 USD",
    "price_postapoc": "5 USD",
    "material": [ "hydrocarbons" ],
    "symbol": "=",
    "color": "red",
    "count": 35,
    "stack_size": 35,
    "ammo_type": "weldgas",
    "phase": "liquid",
    "effects": [ "COOKOFF" ],
    "explode_in_fire": true,
    "explosion": { "power": 20, "shrapnel": 0 },
    "flags": [ "NO_DROP", "IRREMOVABLE" ]
  },

Attach save file

N/A

Steps to reproduce

  1. Learn all recipes
  2. Search for acetylene
  3. Observe that they are different items

OR look into the code.

Expected behavior

I can distinguish different items in the game by their name.

Screenshots

No response

Versions and configuration

  • OS: Windows
    • OS Version: 10.0.19045.4412 (22H2)
  • Game Version: 0.G-9784-g96401952f5-dirty [64-bit] - master was 9640195
  • Graphics Version: Tiles
  • Game Language: English [en]
  • Mods loaded: [
    Dark Days Ahead [dda],
    Disable NPC Needs [no_npc_food],
    Portal Storms Ignore NPCs [personal_portal_storms],
    Slowdown Fungal Growth [no_fungal_growth]
    ]

Additional context

No response

@Brambor Brambor added the (S1 - Need confirmation) Report waiting on confirmation of reproducibility label Jun 2, 2024
@Kamayana
Copy link
Contributor

Kamayana commented Jun 2, 2024

It's strange that oxyacetylene is even a distinct item at all - in real life there are separate canisters for both the acetylene and oxygen, they don't get mixed together into one like the oxyacetylene recipe is implying.

@XygenSS
Copy link
Contributor

XygenSS commented Jun 2, 2024

It's strange that oxyacetylene is even a distinct item at all - in real life there are separate canisters for both the acetylene and oxygen, they don't get mixed together into one like the oxyacetylene recipe is implying.

Probably because we don't have multimag yet

@Karol1223
Copy link
Contributor

/confirm seen this a while ago

@github-actions github-actions bot added (S2 - Confirmed) Bug that's been confirmed to exist and removed (S1 - Need confirmation) Report waiting on confirmation of reproducibility labels Jun 2, 2024
@Brambor
Copy link
Contributor Author

Brambor commented Jun 2, 2024

It was renamed to the same name in

Locally I just renamed it back to oxyacetylene so that I know what is going on. Readability is more important than realism.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
(S2 - Confirmed) Bug that's been confirmed to exist
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants