Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Favorite ammo is no longer marked #72761

Closed
osuphobia opened this issue Apr 1, 2024 · 1 comment
Closed

Favorite ammo is no longer marked #72761

osuphobia opened this issue Apr 1, 2024 · 1 comment
Labels
(S1 - Need confirmation) Report waiting on confirmation of reproducibility stale Closed for lack of activity, but still valid.

Comments

@osuphobia
Copy link
Contributor

osuphobia commented Apr 1, 2024

Describe the bug

I'm overhauling the favorite ammo feature, and found out that after #70359 the way it works changed.

Since OzoneH3 added this feature, favorite ammo used to be marked with a * in ammo selection.
return ( ammo_location && ammo_location == e.ammo ? "* " : "" ) + e.ammo->display_name();
But this line in character_ammo.cpp is simply removed after the migration ae0c892, and you can no longer see the difference between favorite ammo and non-favorite ammo in F fallback now. It's confusing.

Attach save file

N/A

Steps to reproduce

  1. Spwan a longbow and two kind of arrows.
  2. Press F to select favorite ammo.
  3. See the difference before and after the migration.

Expected behavior

Favorite ammo should be marked.

Screenshots

Before
b1
b2
After
a1

Versions and configuration

  • OS: Windows
    • OS Version: 10.0.22631.3296 (23H2)
  • Game Version: d2b51fd [64-bit]
  • Graphics Version: Tiles
  • Game Language: English [en]
  • Mods loaded: [
    Dark Days Ahead [dda],
    Disable NPC Needs [no_npc_food],
    Portal Storms Ignore NPCs [personal_portal_storms],
    Slowdown Fungal Growth [no_fungal_growth]
    ]

Additional context

No response

@osuphobia osuphobia added the (S1 - Need confirmation) Report waiting on confirmation of reproducibility label Apr 1, 2024
@osuphobia osuphobia changed the title Favorite ammo is not longer marked Favorite ammo is no longer marked Apr 1, 2024
Copy link
Contributor

github-actions bot commented May 1, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not bump or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

@github-actions github-actions bot added the stale Closed for lack of activity, but still valid. label May 1, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
(S1 - Need confirmation) Report waiting on confirmation of reproducibility stale Closed for lack of activity, but still valid.
Projects
None yet
Development

No branches or pull requests

1 participant