Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Palettes containing parameters shouldn't be skipped regardless of whether rows is specified #72511

Closed
Procyonae opened this issue Mar 20, 2024 · 0 comments · Fixed by #72699
Closed
Labels
(S1 - Need confirmation) Report waiting on confirmation of reproducibility

Comments

@Procyonae
Copy link
Contributor

Describe the bug

The "palettes" member is skipped when "rows" is unspecified which leads to having to define empty rows like the example below which cause bloat to an otherwise nice method of simplifying mapgen and reducing bloat where palette parameters are required for nest placement.

  {
    "type": "mapgen",
    "method": "json",
    "om_terrain": "derelict_property",
    "//": "rows only defined because otherwise palettes, needed for parameter selection, throws a skipped member error",
    "object": {
      "rows": [
        "                        ",
        "                        ",
        "                        ",
        "                        ",
        "                        ",
        "                        ",
        "                        ",
        "                        ",
        "                        ",
        "                        ",
        "                        ",
        "                        ",
        "                        ",
        "                        ",
        "                        ",
        "                        ",
        "                        ",
        "                        ",
        "                        ",
        "                        ",
        "                        ",
        "                        ",
        "                        ",
        "                        "
      ],
      "fallback_predecessor_mapgen": "forest",
      "palettes": [ "derelict_variant_parameter_palette" ],
      "place_nested": [ { "chunks": [ { "param": "variant", "fallback": "derelict_property_1" } ], "x": 0, "y": 0 } ]
    }
  },

Attach save file

N/A

Steps to reproduce

Remove "rows" from "derelict_property"
Open game
Get skipped member error

Expected behavior

Remove "rows" from "derelict_property"
Open game
Everything peachy

Screenshots

No response

Versions and configuration

N/A

Additional context

No response

@Procyonae Procyonae added the (S1 - Need confirmation) Report waiting on confirmation of reproducibility label Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
(S1 - Need confirmation) Report waiting on confirmation of reproducibility
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant