Swappable player outfits

[RenechCDDA]

Summary

Features "The player can swap between defined outfits with the 'set of clothes' item"

Purpose of change

Many, many feature requests, though none that haven't been killed by stale bot.

Describe the solution

An item, "Set of clothes" with a new use action "CHANGE_OUTFIT"

Changing outfit works by 'a'ctivating the item. It happens instantly to the player's eyes (move costs to put on/take off are still subtracted), but code-wise it is pretty simple. First it spawns a new outfit, then goes over the player's clothes and puts them all into the new outfit's pocket. Once that's done, the activated outfit is iterated over and each contained item is worn by the player (or dropped if unwearable).

Describe alternatives you've considered

N/A this is the alternative

Testing

2024-03-12.17-28-37.mp4

Additional context

Minor known issues:
There is no way (AFAIK) to interrupt changing, so if you had a lot of huge bulky clothes and they took a while to put on, you could put yourself into a dangerous situation accidentally. Resolved by moving to an activity actor.

[mqrause]

There is no way (AFAIK) to interrupt changing, so if you had a lot of huge bulky clothes and they took a while to put on, you could put yourself into a dangerous situation accidentally.

You can and should make this an activity that you assign in the iuse. Taking off and wearing a bunch of clothing/armor is far too long an action to be uninterruptible.

[carlarctg]

I'd really love it if this was made a little less 'magical'. instead of the abstract item being visible and tangible, have it be craftable from a duffel bag, with maybe a lesser capacity makeshift and another primitive version.

[RenechCDDA]

You can and should make this an activity that you assign in the iuse. Taking off and wearing a bunch of clothing/armor is far too long an action to be uninterruptible.

Do you have any recommendations for how to handle the case of an interruption? Currently if you just stopped in the middle you would be left with more clothes than previously existed and an extra outfit_storage, and there's no way for it to 'know' how to clean up. (The direct answer is 'tell it how to clean up' but I would prefer to avoid scenarios where this is possible at all.)

I guess I could properly iterate over the components and erase each one as it is taken out/delete it off your person as it is put in, but the current approach was a significant boon in terms of simplicity.

[I-am-Erk]

I'd really love it if this was made a little less 'magical'. instead of the abstract item being visible and tangible, have it be craftable from a duffel bag, with maybe a lesser capacity makeshift and another primitive version.

except why would you need a duffel bag? An 'outfit' is an abstract concept, you can just point to a pile of unsorted clothes and say "the jeans, red t-shirt, and black hoodie are my outfit", it's not magical. The idea here is that your avatar is lumping these things together and remembering that they belong as one, but they don't have to be stuffed into the same bag for that.

[RenechCDDA]

I'll get back to this once we're done with the 0.H push. The basic idea for implementing it as an activity is simple: At the start of the activity, get the movecost for taking off all your items and putting on all the new ones. Do not actually do that yet.. Set the movecost for the activity.

When activity finishes, instantly do all the wearing at once. Then, set moves to 0 (clearing your move debt). This allows the activity to be interruptible, but without having to deal with interrupting it in the middle, at least in the current iteration.

From the development discord, #development channel
https://discord.com/channels/598523535169945603/598535827169083403/1217988768196464783

[github-actions]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not bump or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

[RenechCDDA]

Shoo, begone. I banish thee, stalebot.

[I-am-Erk]

Yay

[RenechCDDA]

Yay

Basic build passed, quickly merge it before stalebot comes back!