Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression--METABOLISM of 0 causes the game to hang. #72242

Closed
Standing-Storm opened this issue Mar 8, 2024 · 5 comments · Fixed by #72255
Closed

Regression--METABOLISM of 0 causes the game to hang. #72242

Standing-Storm opened this issue Mar 8, 2024 · 5 comments · Fixed by #72255
Labels
(S2 - Confirmed) Bug that's been confirmed to exist

Comments

@Standing-Storm
Copy link
Contributor

Describe the bug

Setting METABOLISM to zero (such as by enchantment with { "value": "METABOLISM", "multiply": -1.0 }) causes the game to hang indefinitely on the turn after it's set. This was explicitly fixed in #69894, so there's been a regression since then.

Attach save file

Hagerstown-trimmed.tar.gz

Steps to reproduce

  1. Cast the spell Stones' Fortitude, which reduces metabolism to zero at max level.
  2. Attempt to move
  3. Game hangs indefinitely

Expected behavior

Metabolism of 0 is supported post- #69894

Screenshots

No response

Versions and configuration

  • OS: Windows
    • OS Version: 10.0.19045.4046 (22H2)
  • Game Version: 9f08089 [64-bit]
  • Graphics Version: Tiles
  • Game Language: English [en]
  • Mods loaded: [
    Dark Days Ahead [dda],
    Disable NPC Needs [no_npc_food],
    Portal Storms Ignore NPCs [personal_portal_storms],
    Slowdown Fungal Growth [no_fungal_growth],
    Magiclysm [magiclysm]
    ]

Additional context

No response

@Standing-Storm Standing-Storm added the (S1 - Need confirmation) Report waiting on confirmation of reproducibility label Mar 8, 2024
@rty275
Copy link
Contributor

rty275 commented Mar 8, 2024

This must be a relatively new regression, I was using Stone's Fortitude at max level successfully as recently as a month or less ago.

EDIT: I actually can't reproduce this. Loading your save gives me an error saying "A relic attempted to load invalid enchantment CARDIO_MULTIPLIER", but casting the spell doesn't cause any problems for me. I also tried the spell in a world of my own and found no issues

@Standing-Storm
Copy link
Contributor Author

Are you on the most recent experimental? The message A relic attempted to load invalid enchantment CARDIO_MULTIPLIER makes me think your game is from before #72106 was merged.

@rty275
Copy link
Contributor

rty275 commented Mar 8, 2024

I realized I wasn't moments after saying that, wanted to update and check before coming back here so I didn't have to edit again. Yeah, I can reproduce it so the bug occurred somewhere between build 2024-03-07-0457 and now. That's my bad for not getting up to date before testing.

@GuardianDll
Copy link
Member

/confirmed
image-123

@github-actions github-actions bot added (S2 - Confirmed) Bug that's been confirmed to exist and removed (S1 - Need confirmation) Report waiting on confirmation of reproducibility labels Mar 8, 2024
@rty275
Copy link
Contributor

rty275 commented Mar 8, 2024

A bit more testing, it's something that happened between 2024-03-07-2013 and build 2024-03-07-2353, and while I don't have the coding expertise to actually diagnose where things went wrong, out of those three PRs in the changelog for that build, #72106 seems like the only thing that touched metabolism. I have no idea how to debug or diagnose from here, so I'll leave the rest of that to y'all, but I hope I helped a little in detecting which build caused the difference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
(S2 - Confirmed) Bug that's been confirmed to exist
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants