-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add SKIP_VERIFICATION option and --noverify cli flag #71645
Conversation
Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details. Click to expand
This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to |
Need to make sure that no consistency check function does anything with the objects that normally should go to finalize function. |
I checked through every function in check_consistency. Almost all of them are I fixed a few that didn't |
Summary
None
Purpose of change
While developing, it's common for me to relaunch the game frequently to test
C++ changes. The verification step takes quite a long time, and especially for
UI changes, is wasted time—it's testing the same thing every time.
Describe the solution
Add an option to turn this off, as well as a CLI flag to skip it for ease of
access when developing.
Describe alternatives you've considered
Perhaps this should be a CLI flag only? The option was the easiest way I could
find to plumb the bool from the CLI to the init code, but it wouldn't be too
hard to add a global or some other plumbing instead.
Or, the verification step should only run if some input to it has changed (e.g.
if the flatbuffer cache was updated).
Testing
Additional context