Items deleted when transfering items

[Secareh]

Describe the bug

I was transfering medicine into my IFAK Pouch and the game gave me this error and deleted every single piece of my med and left me with 1 medicine gauze.

#17
(dbghelp: RtlUserThreadStart+0x21@0x7ffe6e8626b1[ntdll.dll+0x526b1]),
(backtrace_syminfo failed: errno = -1, msg = no symbol table in PE/COFF executable),
(backtrace_pcinfo failed: errno = -1, msg = no debug info in PE/COFF executable),
Backtrace emission took 0 seconds.
(continued from above) ERROR : src/item_contents.cpp:1891 [void item_contents::update_modified_pockets(const std::optional<const pocket_data*>&, std::vector<const pocket_data*>)] Oops! deleted some items when updating pockets that were added via toolmods

Attach save file

Uploading New England-trimmed.tar.gz…

Steps to reproduce

1. Unloaded 18 items. 2 Pill bottles with painkillers, 10 bandages, 5 medical gauzes, 2 plastic bags with medicine.
2. Took off the IFAK Pouch from the MOLLE belt
3. Inserted all of those items by selecting IFAK Pouch with Enter in inventory menu, then by pressing i to insert.

Expected behavior

I wanted to put medical gauze, bandages, pills bottles with painkillers, plastic bags with soaked cotton balls and hemostatic powder. It should've fit because I've placed all of that inside with no problem before it happened.

Screenshots

No response

Versions and configuration

• OS: Windows
  • OS Version: 10.0.19045.3930 (22H2)
• Game Version: 6324dc0 [64-bit]
• Graphics Version: Tiles
• Game Language: System language []
• Mods loaded: [
  Dark Days Ahead [dda],
  Disable NPC Needs [no_npc_food],
  Portal Storms Ignore NPCs [personal_portal_storms],
  Slowdown Fungal Growth [no_fungal_growth],
  Bionic Professions [package_bionic_professions],
  Extra Mutated Scenarios [extra_mut_scens]

Additional context

No response

[emomicrowave]

I can't open / download the attached save file, could you re-upload it please? I tried reproducing by spawning as a combat medic, and spawning a MOLLE belt, and unloading the IFAK, adding items and moving them around, but I can't make the issue happen.

[Secareh]

I can't open / download the attached save file, could you re-upload it please? I tried reproducing by spawning as a combat medic, and spawning a MOLLE belt, and unloading the IFAK, adding items and moving them around, but I can't make the issue happen.

Oh, Christ. I don't have the file any more. All I can say is that the game did that when I was attaching the IFAK few times on my MOLLE Belt, then unloading it few times while the IFAK had items hidden.

[emomicrowave]

Debug - Nomods.zip

So, I managed to reproduce reliably.

1. Load the save and open inventory
2. Select the worn MOLLE webbing belt and (a) attach the IFAK
3. Select the MOLLE belt and (U) unload its contents
4. (a) Activate the belt again and detach the empty IFAK
5. Use ">" to expand the belt, because that's where the IFAK is still
6. (i) to insert as many items as possible to the IFAK - add meds, chems, spare parts and tools
7. (a) the MOLLE belt and attempt to attach the IFAK
   1. this should lead to the error

I suspect it might be something to do with tracking parent pockets etc. Originally I couldn't reproduce, since detaching the IFAK from the belt would place it in the army jacket and pants. But once I dropped these, and gave the game way less available pockets to work with, the bug was reproducible.

I will edit the post in the next few days if I find out more to narrow down the cause, and nobody has replied yet.

---

Okay, so I think I've narrowed it down a bit in-game:

1. If your inventory is pretty full, there is a chance that detaching the IFAK from your belt, will place it inside the belt (even though this shouldn't be allowed).
2. If you add an additional item to the IFAK and attempt to attach it, you will see the error, and items will be deleted.

Unfortunately the whole MOLLE-related code for adding new pockets is a bit confusing to me.

Also found #70354 and #70925 that are likely related, but not duplicates as far as I can tell.

[github-actions]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not bump or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

[kevingranade]

This looks like it was confirmed, and I have no reason to expect it to have been fixed, so marking confirmed and reopening.