Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PC crafting fails to find tank with fluid in inventory #70846

Closed
PatrikLundell opened this issue Jan 11, 2024 · 1 comment
Closed

PC crafting fails to find tank with fluid in inventory #70846

PatrikLundell opened this issue Jan 11, 2024 · 1 comment
Labels
(S1 - Need confirmation) Report waiting on confirmation of reproducibility stale Closed for lack of activity, but still valid.

Comments

@PatrikLundell
Copy link
Contributor

Describe the bug

If you try to craft a charcoal kiln and spawn a 2 L tank into your inventory and then "fill" it with water from a canteen the tank component entry is marked in red with no number beside it.
The tank is found if empty and it's found on the ground by the PC's feet.

Attach save file

N/A. The compressed saves are too large.

Steps to reproduce

  1. Have enough skills to know how to craft a charcoal kiln.
  2. Bring up the crafting menu recipe for the charcoal kiln and note that the 2L tank entry is red with no number beside it.
  3. Debug spawn a 2L tank.
  4. Repeat 2 and see the 2L tank entry is marked in green, with 1 tank available.
  5. "Refill" the tank with e.g. water from a canteen (but anything, including non liquids would do. I've tried it with locking pliars).
  6. Repeat 2 and see that the tank entry is marked in red with no number beside it.
  7. Drop the tank.
  8. Repeat 2 and see that the tank entry is now marked in magenta with a 1 after it, indicating it's a watertight container in use, and there aren't enough empty containers to make the kiln.

Expected behavior

The tank should be available to the recipe in all of these situations, and in particular, shouldn't go from available to unavailable in one location but from available to available with a warning in another when something is placed inside it.

Screenshots

No response

Versions and configuration

  • OS: Windows
    • OS Version: 10.0.19045.3930 (22H2)
  • Game Version: 0.G-6427-g72d5293688 [64-bit]
  • Graphics Version: Tiles
  • Game Language: System language []
  • Mods loaded: [
    Dark Days Ahead [dda],
    Disable NPC Needs [no_npc_food],
    Portal Storms Ignore NPCs [personal_portal_storms],
    Slowdown Fungal Growth [no_fungal_growth]
    ]

Additional context

It's obviously a weird case, but I've stumbled upon it while trying to test my changes for #70826. However, I've hit a wall and fail to locate the reason erroneous data gets generated somewhere upstream if the code I'm involved with.

The reason the tank is marked in red appears to be because the recipe data contain incorrect state info: requirements_.components[1].[0].component.available has the value "a_false". This eventually leads to a failure to try to locate the component (index 1 in the above is the tank entry).

I think this recipe info is generated in a huge "initialize everything when the UI is brought up but before anything is displayed or selected" search somewhere, and I assume something is broken in its logic.

@PatrikLundell PatrikLundell added the (S1 - Need confirmation) Report waiting on confirmation of reproducibility label Jan 11, 2024
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not bump or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

@github-actions github-actions bot added the stale Closed for lack of activity, but still valid. label Feb 10, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
(S1 - Need confirmation) Report waiting on confirmation of reproducibility stale Closed for lack of activity, but still valid.
Projects
None yet
Development

No branches or pull requests

1 participant