Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backgrounds can accept spells, and display the spells in the UI, but don't give you the spells. #70815

Closed
Standing-Storm opened this issue Jan 10, 2024 · 1 comment · Fixed by #71116
Labels
(S1 - Need confirmation) Report waiting on confirmation of reproducibility

Comments

@Standing-Storm
Copy link
Contributor

Describe the bug

Working on #70803 and I have it all set up. It even shows in the UI properly:
image

However, upon actually entering the game, none of those powers are granted. Only the default powers from the Teleporter traits:
image

Attach save file

N/A

Steps to reproduce

  1. Paste the following JSON somewhere in your game and load Mind Over Matter:
    { "type": "profession", "subtype": "hobby", "id": "late_teleporter", "name": "Ascended Teleporter", "description": "Something happened during the storms that raged during the Cataclysm, and now you can do things that would have once seemed impossible. No wall or door is a barrier to you and sometimes when you close your eyes you can travel to places you've already been. Once you were surprised by a bandit and when he leveled his gun at you, you wished he was somewhere else and he just...disappeared. Nothing can keep you down now.", "points": 13, "traits": [ "TELEPORTER", "TELEPORTER_PROTECT" ], "skills": [ { "level": 7, "name": "metaphysics" } ], "spells": [ { "id": "teleport_blink", "level": 11 }, { "id": "teleport_slow", "level": 12 }, { "id": "teleport_displacement", "level": 10 }, { "id": "teleport_stride", "level": 12 }, { "id": "teleport_phase", "level": 12 }, { "id": "teleport_collapse", "level": 7 }, { "id": "teleport_farstep", "level": 10 }, { "id": "teleport_banish", "level": 6 }, { "id": "teleport_gateway", "level": 4 }, { "id": "teleport_area_attune", "level": 1 } ] }
  2. Apply the Ascended Teleporter background to a new character.
  3. Check the spellcasting menu.
  4. Notice that only Blink and Stutterstep, the default powers granted by the TELEPORTER trait, appear.

Expected behavior

The character is granted the powers that the UI tells them they will be granted.

Screenshots

No response

Versions and configuration

  • OS: Windows
    • OS Version: 10.0.19045.3803 (22H2)
  • Game Version: e71d5b1 [64-bit]
  • Graphics Version: Tiles
  • Game Language: English [en]
  • Mods loaded: [
    Dark Days Ahead [dda],
    Disable NPC Needs [no_npc_food],
    Portal Storms Ignore NPCs [personal_portal_storms],
    Slowdown Fungal Growth [no_fungal_growth],
    Mind Over Matter [mindovermatter]
    ]

Additional context

No response

@FlaKougar
Copy link
Contributor

avatar::initialize @ newcharacter.cpp:983 is
prof->learn_spells( *this );
This learns spells just from the profession.
Need to do something like void Character::set_proficiencies_from_hobbies()
to iterate over hobbies and learn spells from them. The current profession->learn_spells handles same spell from multiple hobbies correctly so it should be a straight forward to implement. I don't have a setup to build currently so can't test out a patch for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
(S1 - Need confirmation) Report waiting on confirmation of reproducibility
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants