Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rivers should vary in width depending on distance to ocean #70204

Closed
Procyonae opened this issue Dec 14, 2023 · 3 comments
Closed

Rivers should vary in width depending on distance to ocean #70204

Procyonae opened this issue Dec 14, 2023 · 3 comments
Labels
stale Closed for lack of activity, but still valid. <Suggestion / Discussion> Talk it out before implementing

Comments

@Procyonae
Copy link
Contributor

Is your feature request related to a problem? Please describe.

Now we have an actual ocean rivers should be narrower in the west get gradually thicker to the east

Solution you would like.

A math exposed variable assigned to the 180x180 OM that dictates how wide the rivers on that OM should be

Describe alternatives you have considered.

Ideally they'd also tend to head for the ocean on a macro scale
Ideally rivers would have independent sizes modified by how far from the ocean and able to combine with intersecting rivers rather than forming waterworld esque nightmares like they currently can
The width could be controlled at a smaller scale than OM (like 3 different widths for the bank tiles) which should be doable in future if however this is incorporated is exposed to JSON math once I get around to unhardcoding river maps.
Estuary gen would be cool but I'd rather see #38894 revved first (pls someone, anyone)

Additional context

No response

@Procyonae Procyonae added the <Suggestion / Discussion> Talk it out before implementing label Dec 14, 2023
@PatrikLundell
Copy link
Contributor

Distance from the ocean shouldn't set the river width, but rather the maximum river width. Small water ways should exist everywhere, and the river width should really depend on how large an area is acts as a runoff for (given the constant humidity and fog, there shouldn't be any significant loss of water due to evaporation).

@Procyonae
Copy link
Contributor Author

Distance from the ocean shouldn't set the river width, but rather the maximum river width.

From a realism perspective yes but currently width isn't maintained across map boundaries (the only reason #38894 wasn't merged was they wanted to fix that too as far as I can tell), meaning if you make it a roll the size could fluctuate dramatically between the boundaries, this is an easier in between until someone figures that out

Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not bump or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

@github-actions github-actions bot added the stale Closed for lack of activity, but still valid. label Jan 14, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Closed for lack of activity, but still valid. <Suggestion / Discussion> Talk it out before implementing
Projects
None yet
Development

No branches or pull requests

2 participants