Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translations for names share the same strings as others #70023

Closed
Uwuewsky opened this issue Dec 6, 2023 · 3 comments · Fixed by #70279
Closed

Translations for names share the same strings as others #70023

Uwuewsky opened this issue Dec 6, 2023 · 3 comments · Fixed by #70279
Labels
(S2 - Confirmed) Bug that's been confirmed to exist Translation I18n

Comments

@Uwuewsky
Copy link
Contributor

Uwuewsky commented Dec 6, 2023

Describe the bug

  1. After a commit JSON-ify hallucinations #69919 in the translation file, some names share the same lines as other things like achievements, classes, mutations, actions.
  2. After the same commit, the lines for the names of seasons from the calendar disappeared somewhere - instead of them there were only lines with similar surnames. Season names are also needed separately from surnames.

for example:

#. ~ Name of achievement
#. ~ Snippet in category "<random_last_name>"
#: data/json/achievements.json data/json/snippets/names.json
msgid "Bowman"
#. ~ Snippet in category "<random_female_first_name>"
#: data/json/snippets/names.json
msgid "Autumn"

Winter/Spring/Summer/Autumn
Bowman
High
Ring
Read
Clay
Cotton
Diamond
Glass
Crystal
Gold
Honey
Silver
Stone
Bean
Wood
Field
House
Church
Block
Cross
Sunny
Light
Thrasher
Fish
Bird
Alpha <-(these one same, but maybe not in some language)
Quick
Scales
Hunter
Strong
Smart
Little
Tiny
Shell
Wolf
Bee
Craven
Hacker <-(and these same)
Farmer
Merchant
Miner
Barber
Carpenter
Foreman
Grove
Reed
Forest
Marina
Christian
Pagan

Upd 12.07:
Craft
Gates
Butcher
Sunday
Sugar

(looks like there's a lot more)

Expected behavior

I'm expecting someone will separate these strings according to their context

Versions and configuration

Transifex: master

@Uwuewsky Uwuewsky added the (S1 - Need confirmation) Report waiting on confirmation of reproducibility label Dec 6, 2023
@Maleclypse
Copy link
Member

@MNG-cataclysm

@MNG-cataclysm
Copy link
Contributor

Well, that's not good. @Maleclypse Is there some way for the stuff in the names folder to be pulled into a snippet? If that is possible, then a separate list of names wouldn't need to be maintained, and would only draw from one place.

@Qrox
Copy link
Contributor

Qrox commented Dec 7, 2023

Is there some way for the stuff in the names folder to be pulled into a snippet?

What I can think of is to make a special case in the snippet code to expand the tags into names in the name folder, using this function:

std::string get( nameFlags searchFlags );

@BrettDong BrettDong added Translation I18n (S2 - Confirmed) Bug that's been confirmed to exist and removed (S1 - Need confirmation) Report waiting on confirmation of reproducibility labels Dec 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
(S2 - Confirmed) Bug that's been confirmed to exist Translation I18n
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants