Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3-dimensional Z-level support, Core Part 2: efficiently process active items in 3D [$100] #6820

Closed
GlyphGryph opened this issue Mar 21, 2014 · 8 comments · Fixed by #13588
Closed
Labels
Organization: Bounty Bounties for claim (S2 - Confirmed) Bug that's been confirmed to exist

Comments

@GlyphGryph
Copy link
Contributor

Master Ticket #6822
This will be a "bounty issue" for the development of z-line track development.

This has following requirements:
Process active entities (items, monsters, fields, etc.) on all z-levels.
This should not cause a notable decrease in in performance on an average system.

Did you help close this issue? Go claim the $100 bounty on Bountysource.

@KA101
Copy link
Contributor

KA101 commented Mar 21, 2014

Define "average system"? That'll be a Bugbear, I fear.

@GlyphGryph
Copy link
Contributor Author

We'll be getting specific benchmark figures to hit, hopefully, before anyone starts working on these. I'm just getting up the initial frameworks for now.

@GlyphGryph GlyphGryph changed the title Basic 3-dimensional Z-level support, part 2 3-dimensional Z-level support, Core Part 2 Mar 21, 2014
@CIB
Copy link
Contributor

CIB commented Mar 21, 2014

This should not cause a notable decrease in in performance on an average system.

I assume this is refering to the average case of just one z-level actually being used? I can guarantee you, setting a skyscraper on fire will be slower than setting a 1-story house on fire, and with good reason.

@KA101
Copy link
Contributor

KA101 commented Mar 21, 2014

I assume this is refering to the average case of just one z-level actually being used? I can guarantee you, setting a skyscraper on fire will be slower than setting a 1-story house on fire, and with good reason.

That's as may be, but if it lags the game into unplayability, then we don't have functioning z-levels. Worst case, worldgen option to cap the amount of aboveground z-levels (with menu suggestions for various hardware?) could be a workaround.

@kevingranade kevingranade changed the title 3-dimensional Z-level support, Core Part 2 3-dimensional Z-level support, Core Part 2: efficiently process active items in 3D Apr 10, 2014
@kevingranade kevingranade changed the title 3-dimensional Z-level support, Core Part 2: efficiently process active items in 3D 3-dimensional Z-level support, Core Part 2: efficiently process active items in 3D [$100] Aug 27, 2014
@kevingranade kevingranade added the Organization: Bounty Bounties for claim label Sep 20, 2014
@Coolthulhu
Copy link
Contributor

Does this need anything more?
The only "notable decrease in performance" I see here would be the larger number of monsters that can happen, but the only big multi-z-level structure we have right now is the lab and those seem to work fine, at least in my tests.

@kevingranade
Copy link
Member

kevingranade commented Aug 31, 2015 via email

@Coolthulhu
Copy link
Contributor

What about the first part (ie. process stuff on all z-levels)?
I extended the code to cover (almost?) all of the stuff and did some minor optimization (mostly fields, because fire was not "3D-ready"). Can I get a part of the bounty?

@kevingranade
Copy link
Member

kevingranade commented Aug 31, 2015 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Organization: Bounty Bounties for claim (S2 - Confirmed) Bug that's been confirmed to exist
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants