The vehicel mounted heaters and the cooler use like 20 times more energy than there description says they need!

[Krieger1999]

Describe the bug

While testing the vehicel mounted heater and cooler, i noticed that they use up way more energy than the description from them says. Even while seeing that iam producing more energy, than i should consume, i still lost energy and my battery drained.

Attach save file

Steps to reproduce

1. Spawn a solar vehicel with at least 1000 energy production in debug mode
2. Install a vehicel mounted cooler or heater and turn it on and see if your energy consumption is still higher than your energy lose, and make sure your storage battery is full
3. Wait like 5 or 30 minutes and look at your storage battery and see that even though you produce more energy than you consume, you still drained your battery

Expected behavior

Your storage battery should remain at 100%, as long as you have an energy surplus.

Screenshots

No response

Versions and configuration

Windows 10
Build: 2023-06-16-0558
Version: d5cc239 (tiles)
Mods: Dark days ahead [dda],
Blaze Industries [blazeindustries],
Magiclysm [magiclysm],
Xedra Evolved [xedra_evolved],

Additional context

No response

[SurFlurer]

Can /confirm . I observed the same phenomenon.

[SurFlurer]

More precisely it's this part:

Cataclysm-DDA/src/vehicle.cpp

Lines 7480 to 7498 in 6d6c3a2

	const time_duration interval = pt.info().has_flag( VPFLAG_ENABLED_DRAINS_EPOWER )
	? update_to - last_update - 1_seconds
	: update_to - last_update;
	if( interval < 0_seconds ) {
	debugmsg( "emitter simulating negative time interval, something is fishy / buggy" );
	break;
	}
	discharge_battery( power_to_energy_bat( -pt.info().epower, interval ) );
	}
	if( sm_pos.z < 0 ) {
	last_update = update_to;
	return;
	}
	if( update_to >= update_from && update_to - update_from < 1_minutes ) {
	// We don't need to check every turn
	return;
	}

So last_update doesn't get updated every turn, but interval assumes this.